Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reV updates #10

Merged
merged 61 commits into from
Aug 10, 2023
Merged

reV updates #10

merged 61 commits into from
Aug 10, 2023

Conversation

ppinchuk
Copy link
Collaborator

Updates to support running reV on GAPs.
Includes quite a few QOL upgrades and bug fixes.

@ppinchuk
Moved and updated GAPS_SUPPLIED_ARGS
d78df6d
@ppinchuk
Logging parameters now passed to preprocessor
cd4b5e4
@ppinchuk
Updated docstrings
157410c
@ppinchuk
Added info logging
b75e0c0
@ppinchuk
Log command name
7fdc24b
@ppinchuk
More thorough test for _should_run function
e4a15a6
@ppinchuk
Add missing command name in log
0928a4a
@ppinchuk
Added logging to status updates
df31e7e
@ppinchuk
Updated order of logging statements
cd2854e
@ppinchuk
Added to QOS documentation
386b999
@ppinchuk
Minor docstring updates
74cc127
@ppinchuk
Update docstrings
7eae807
@ppinchuk
Allow extra args to be added to exec control
5fbe55b
@ppinchuk
Add main CLI help docs
a252d44
@ppinchuk
Minor docstring updates
90ea6d8
@ppinchuk
More typo fixes
e8673c8
@ppinchuk
Add extra command help documentation
03f7807
@ppinchuk
Added minor text to doc
1a9c636
@ppinchuk
Documentation updates
87323f9
@ppinchuk
Update README with more info about target audience
6975ec1
@ppinchuk
Add explanation about tag to docs
6978423
@ppinchuk
Added extra tests for pipeline specification
b7bee0e
@ppinchuk
Add split_keys=None test
bdd3117
@ppinchuk
Added test and docs for empty split key input
bfa508a
@ppinchuk
Log messages no longer propagate to root logger
1acf53c
@ppinchuk
More detailed logger print statement
1b08c1d
@ppinchuk
Updated variable name to memory_utilization_limit
102306d
@ppinchuk
Updated pipeline log docs
63cb9a2
@ppinchuk
Fix bug with stdout not returning properly
e66907c
@ppinchuk
Update documentation
7507930
@ppinchuk
Added timestamp to monitor output
1f8af50
@ppinchuk
Fix error message
a28cb90
@ppinchuk
Add reset_query_cache function
dd07f7e
@ppinchuk
Monitor jobs now correctly query the hardware
e8c4161
@ppinchuk
Updated status option check to be more robust
a55d0fd
@ppinchuk
Do not submit pipeline if another monitor pipeline is already running
2198571
@ppinchuk
Monitor jobs now cancelled if exdception detected
fe04d39
@ppinchuk
Cancelling jobs is now hardware-aware
984d61a
@ppinchuk
Update logger initialization
b27c3e5
@ppinchuk
Tabs now grouped together in docs
b10ccbc
@ppinchuk
Set max width on terminal to look good with docs
c5da395
@ppinchuk
Add _is_sphinx_build utility function
da1c6f3
@ppinchuk
CLI command now says "Config Parameters"
1087692
@ppinchuk
Big update to documentation formatting to support pretty docs in both…
8105c82 
… CLI and SPhinx
@ppinchuk
Minor formatting
ddee6ae
@ppinchuk
Add zfill fix
bb6014a
@ppinchuk
Add support for JSON5
31ecfb8
@ppinchuk
Add GHA to run reV CLI tests
d19d24d
@ppinchuk
Expanded collection tests slightly
da5fc8d
@ppinchuk
Updated status output
aba2f9c
@ppinchuk
Updated tests to be more robust against messages in result
a3ad402
@ppinchuk
Bump version
5b805b1
@ppinchuk
Better str comparison in test
6966cfd
@ppinchuk
Install pytest with gaps
8ccba10
@ppinchuk
Increase wait limit for test
da8ac58
@ppinchuk
Increase wait time in tests again
ce9fd12
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 95.21% and project coverage change: -0.27% ⚠️

Comparison is base (10b2722) 98.57% compared to head (ce9fd12) 98.31%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   98.57%   98.31%   -0.27%     
==========================================
  Files          26       26              
  Lines        2460     2665     +205     
  Branches      407      444      +37     
==========================================
+ Hits         2425     2620     +195     
- Misses         22       31       +9     
- Partials       13       14       +1
Flag Coverage Δ
unittests 98.31% <95.21%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
gaps/cli/preprocessing.py 100.00% <ø> (ø)
gaps/cli/templates.py 100.00% <ø> (ø)
gaps/cli/status.py 88.09% <81.63%> (-10.26%) ⬇️
gaps/__init__.py 100.00% <100.00%> (ø)
gaps/batch.py 100.00% <100.00%> (ø)
gaps/cli/batch.py 100.00% <100.00%> (ø)
gaps/cli/cli.py 100.00% <100.00%> (ø)
gaps/cli/command.py 100.00% <100.00%> (ø)
gaps/cli/config.py 100.00% <100.00%> (+1.03%) ⬆️
gaps/cli/documentation.py 100.00% <100.00%> (ø)
... and 11 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit f66c12f into main Aug 10, 2023
9 checks passed
@ppinchuk ppinchuk deleted the pp/rev-updates branch August 10, 2023 04:15
github-actions bot pushed a commit that referenced this pull request Aug 10, 2023
@ppinchuk
Merge pull request #10 from NREL/pp/rev-updates
74f775c 
reV updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppinchuk @codecov-commenter